Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove repetitive words #3628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gcmutator
Copy link

@gcmutator gcmutator commented Mar 9, 2024

Description

remove repetitive words

Checklist

  • I have reviewed my own code
  • I have added tests

Signed-off-by: gcmutator <329964069@qq.com>
Copy link

github-actions bot commented Mar 9, 2024

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.807 ns      │ 3.484 ns      │ 2.815 ns      │ 2.832 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.809 ns      │ 3.219 ns      │ 2.817 ns      │ 2.827 ns      │ 100     │ 1000000000

Copy link

github-actions bot commented Mar 9, 2024

Visit the preview URL for this PR (updated for commit c3d0d9d):

https://yew-rs--pr3628-master-4lu46pa2.web.app

(expires Sat, 16 Mar 2024 03:55:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

github-actions bot commented Mar 9, 2024

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 98.845 98.845 0 0.000%
boids 171.354 171.354 0 0.000%
communication_child_to_parent 91.513 91.513 0 0.000%
communication_grandchild_with_grandparent 103.752 103.752 0 0.000%
communication_grandparent_to_grandchild 99.176 99.176 0 0.000%
communication_parent_to_child 87.859 87.859 0 0.000%
contexts 103.879 103.879 0 0.000%
counter 84.777 84.777 0 0.000%
counter_functional 84.903 84.903 0 0.000%
dyn_create_destroy_apps 87.752 87.752 0 0.000%
file_upload 98.939 98.939 0 0.000%
function_memory_game 169.629 169.629 0 0.000%
function_router 346.408 346.408 0 0.000%
function_todomvc 159.868 159.868 0 0.000%
futures 227.015 227.015 0 0.000%
game_of_life 108.243 108.243 0 0.000%
immutable 187.456 187.456 0 0.000%
inner_html 78.634 78.634 0 0.000%
js_callback 107.484 107.484 0 0.000%
keyed_list 196.810 196.810 0 0.000%
mount_point 81.438 81.438 0 0.000%
nested_list 112.511 112.511 0 0.000%
node_refs 88.905 88.905 0 0.000%
password_strength 1707.784 1707.784 0 0.000%
portals 92.059 92.059 0 0.000%
router 315.536 315.536 0 0.000%
simple_ssr 139.426 139.426 0 0.000%
ssr_router 385.924 385.924 0 0.000%
suspense 113.986 113.986 0 0.000%
timer 87.458 87.458 0 0.000%
timer_functional 96.317 96.317 0 0.000%
todomvc 140.444 140.444 0 0.000%
two_apps 84.153 84.153 0 0.000%
web_worker_fib 133.673 133.673 0 0.000%
web_worker_prime 183.743 183.743 0 0.000%
webgl 81.282 81.282 0 0.000%

✅ None of the examples has changed their size significantly.

Copy link

github-actions bot commented Mar 9, 2024

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.897 309.706 309.188 0.289
Hello World 10 499.411 508.516 504.008 4.170
Function Router 10 1657.819 1690.828 1671.976 9.364
Concurrent Task 10 1005.585 1007.218 1006.339 0.461
Many Providers 10 1138.777 1181.618 1156.834 14.241

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.902 309.505 309.130 0.202
Hello World 10 484.187 521.144 490.614 11.369
Function Router 10 1628.790 1651.063 1635.345 6.524
Concurrent Task 10 1005.770 1006.635 1006.191 0.270
Many Providers 10 1134.623 1174.168 1147.221 13.498

Copy link
Member

@hamza1311 hamza1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants