Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queries in ssr_router example #3587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Oliver-Bilbie
Copy link

Description

Fixed a bug where the ssr_router example would panic when query parameters were passed.

Checklist

  • I have reviewed my own code
  • I have added tests

Copy link

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 101.144 101.144 0 0.000%
boids 174.688 174.688 0 0.000%
communication_child_to_parent 93.555 93.555 0 0.000%
communication_grandchild_with_grandparent 106.486 106.486 0 0.000%
communication_grandparent_to_grandchild 101.738 101.738 0 0.000%
communication_parent_to_child 89.891 89.891 0 0.000%
contexts 106.636 106.636 0 0.000%
counter 86.929 86.929 0 0.000%
counter_functional 87.330 87.330 0 0.000%
dyn_create_destroy_apps 89.736 89.736 0 0.000%
file_upload 100.715 100.715 0 0.000%
function_memory_game 173.401 173.401 0 0.000%
function_router 349.626 349.626 0 0.000%
function_todomvc 162.125 162.125 0 0.000%
futures 230.393 230.393 0 0.000%
game_of_life 111.037 111.037 0 0.000%
immutable 188.747 188.747 0 0.000%
inner_html 80.631 80.631 0 0.000%
js_callback 110.349 110.349 0 0.000%
keyed_list 200.100 200.100 0 0.000%
mount_point 83.528 83.528 0 0.000%
nested_list 114.709 114.709 0 0.000%
node_refs 91.046 91.046 0 0.000%
password_strength 1751.200 1751.200 0 0.000%
portals 94.224 94.224 0 0.000%
router 318.512 318.512 0 0.000%
simple_ssr 141.241 141.241 0 0.000%
ssr_router 387.809 387.809 0 0.000%
suspense 116.475 116.475 0 0.000%
timer 89.393 89.393 0 0.000%
timer_functional 98.763 98.763 0 0.000%
todomvc 142.437 142.437 0 0.000%
two_apps 86.646 86.646 0 0.000%
web_worker_fib 135.509 135.509 0 0.000%
web_worker_prime 185.938 185.938 0 0.000%
webgl 83.187 83.187 0 0.000%

✅ None of the examples has changed their size significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant