Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context: cleanup - avoid storing a copy of children #2885

Merged
merged 1 commit into from Sep 25, 2022
Merged

Context: cleanup - avoid storing a copy of children #2885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 5 additions & 11 deletions packages/yew/src/context.rs
View file
Open in desktop
Expand Up @@ -24,7 +24,6 @@ pub struct ContextProviderProps<T: Clone + PartialEq> {
#[derive(Debug)]
pub struct ContextProvider<T: Clone + PartialEq + 'static> {
context: T,
children: Children,
consumers: RefCell<Slab<Callback<T>>>,
}

Expand Down Expand Up @@ -85,20 +84,15 @@ impl<T: Clone + PartialEq + 'static> Component for ContextProvider<T> {
fn create(ctx: &Context<Self>) -> Self {
let props = ctx.props();
Self {
children: props.children.clone(),
context: props.context.clone(),
consumers: RefCell::new(Slab::new()),
}
}

fn changed(&mut self, ctx: &Context<Self>, _old_props: &Self::Properties) -> bool {
fn changed(&mut self, ctx: &Context<Self>, old_props: &Self::Properties) -> bool {
let props = ctx.props();
let should_render = if self.children == props.children {
false
} else {
self.children = props.children.clone();
true
};

let should_render = old_props.children != props.children;

if self.context != props.context {
self.context = props.context.clone();
Expand All @@ -108,7 +102,7 @@ impl<T: Clone + PartialEq + 'static> Component for ContextProvider<T> {
should_render
}

fn view(&self, _ctx: &Context<Self>) -> Html {
html! { <>{ self.children.clone() }</> }
fn view(&self, ctx: &Context<Self>) -> Html {
html! { <>{ ctx.props().children.clone() }</> }
}
}