Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Yew lints opt-in #2882

Merged
merged 5 commits into from Sep 25, 2022
Merged

Make Yew lints opt-in #2882

merged 5 commits into from Sep 25, 2022

Conversation

hamza1311
Copy link
Member

Description

Add a compiler flag (--cfg yew_lints) to enable lints for html! macro

Fixes #2360

Checklist

  • I have reviewed my own code
  • I have added tests

@hamza1311 hamza1311 added the A-yew-macro Area: The yew-macro crate label Sep 24, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 24, 2022
@github-actions
Copy link

github-actions bot commented Sep 24, 2022

Visit the preview URL for this PR (updated for commit faf477a):

https://yew-rs-api--pr2882-cfg-yew-lints-rij5fkx4.web.app

(expires Sat, 01 Oct 2022 19:29:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot]
github-actions bot previously approved these changes Sep 24, 2022
@github-actions
Copy link

github-actions bot commented Sep 24, 2022

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 374.811 375.573 375.105 0.259
Hello World 10 660.933 662.953 661.977 0.643
Function Router 10 2376.570 2410.030 2391.286 11.951
Concurrent Task 10 1007.216 1008.999 1008.217 0.581

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 393.260 393.552 393.421 0.086
Hello World 10 656.090 661.220 657.995 1.590
Function Router 10 2371.209 2390.127 2381.762 5.330
Concurrent Task 10 1007.635 1008.963 1008.263 0.469

@github-actions
Copy link

github-actions bot commented Sep 24, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 170.324 170.330 +0.006 +0.003%
communication_child_to_parent 90.509 90.509 0 0.000%
communication_grandchild_with_grandparent 105.467 105.460 -0.007 -0.006%
communication_grandparent_to_grandchild 101.361 101.355 -0.006 -0.006%
communication_parent_to_child 87.649 87.649 0 0.000%
contexts 107.897 107.887 -0.011 -0.010%
counter 85.521 85.521 0 0.000%
counter_functional 86.052 86.049 -0.003 -0.003%
dyn_create_destroy_apps 88.429 88.429 0 0.000%
file_upload 100.101 100.102 +0.001 +0.001%
function_memory_game 163.229 163.224 -0.005 -0.003%
function_router 348.056 348.059 +0.003 +0.001%
function_todomvc 158.022 158.031 +0.009 +0.006%
futures 222.433 222.434 +0.001 +0.000%
game_of_life 105.062 105.062 0 0.000%
immutable 181.736 181.734 -0.002 -0.001%
inner_html 82.389 82.388 -0.001 -0.001%
js_callback 111.420 111.418 -0.002 -0.002%
keyed_list 195.600 195.600 0 0.000%
mount_point 85.139 85.141 +0.002 +0.002%
nested_list 111.954 111.954 0 0.000%
node_refs 93.041 93.042 +0.001 +0.001%
password_strength 1547.542 1547.542 0 0.000%
portals 96.332 96.332 0 0.000%
router 317.760 317.769 +0.009 +0.003%
simple_ssr 152.243 152.244 +0.001 +0.001%
ssr_router 393.625 393.636 +0.011 +0.003%
suspense 109.148 109.148 0 0.000%
timer 88.339 88.337 -0.002 -0.002%
todomvc 139.122 139.120 -0.002 -0.001%
two_apps 86.134 86.135 +0.001 +0.001%
web_worker_fib 152.375 152.390 +0.015 +0.010%
webgl 84.827 84.827 0 0.000%

✅ None of the examples has changed their size significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-macro Area: The yew-macro crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a way to opt-out from yew lints
2 participants