Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume Suspension upon unmount #2874

Merged
merged 4 commits into from Sep 15, 2022

Conversation

futursolo
Copy link
Member

Description

Fixes #2873

This behaviour was initially implemented but was wrongly removed in a subsequent pull request causing the suspension to be unable to resume upon destroy.
This pull request restores this behaviour.

Checklist

  • I have reviewed my own code
  • I have added tests

github-actions[bot]
github-actions bot previously approved these changes Sep 15, 2022
@github-actions
Copy link

github-actions bot commented Sep 15, 2022

Visit the preview URL for this PR (updated for commit 9aced41):

https://yew-rs-api--pr2874-resume-on-unmount-piwebvzi.web.app

(expires Thu, 22 Sep 2022 12:28:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Sep 15, 2022

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 412.496 428.595 415.653 4.675
Hello World 10 732.154 739.621 737.074 2.206
Function Router 10 2697.669 2721.517 2710.287 6.771
Concurrent Task 10 1009.505 1013.474 1011.214 1.276

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 365.552 369.209 367.837 1.197
Hello World 10 740.170 746.223 743.957 1.789
Function Router 10 2601.161 2613.762 2607.987 4.143
Concurrent Task 10 1008.851 1012.629 1010.128 1.074

github-actions[bot]
github-actions bot previously approved these changes Sep 15, 2022
@github-actions
Copy link

github-actions bot commented Sep 15, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 170.250 170.253 +0.003 +0.002%
communication_child_to_parent 90.458 90.467 +0.009 +0.010%
communication_grandchild_with_grandparent 105.416 105.425 +0.009 +0.008%
communication_grandparent_to_grandchild 101.312 101.319 +0.007 +0.007%
communication_parent_to_child 87.589 87.609 +0.021 +0.023%
contexts 107.844 107.849 +0.005 +0.005%
counter 85.496 85.481 -0.015 -0.017%
counter_functional 86.023 86.008 -0.016 -0.018%
dyn_create_destroy_apps 88.395 88.407 +0.013 +0.014%
file_upload 100.074 100.058 -0.017 -0.017%
function_memory_game 163.783 163.810 +0.026 +0.016%
function_router 348.455 348.521 +0.066 +0.019%
function_todomvc 158.605 158.614 +0.009 +0.006%
futures 221.970 221.952 -0.018 -0.008%
game_of_life 105.761 105.745 -0.016 -0.015%
immutable 181.590 181.701 +0.111 +0.061%
inner_html 82.361 82.345 -0.017 -0.020%
js_callback 111.371 111.386 +0.015 +0.013%
keyed_list 195.560 195.562 +0.002 +0.001%
mount_point 85.116 85.099 -0.018 -0.021%
nested_list 112.592 112.598 +0.006 +0.005%
node_refs 92.980 92.989 +0.009 +0.009%
password_strength 1547.872 1547.878 +0.006 +0.000%
portals 96.277 96.291 +0.014 +0.014%
router 318.133 318.154 +0.021 +0.007%
simple_ssr 152.173 152.194 +0.021 +0.014%
ssr_router 393.991 394.002 +0.011 +0.003%
suspense 109.187 109.189 +0.003 +0.003%
timer 88.338 88.320 -0.018 -0.020%
todomvc 139.732 139.716 -0.017 -0.012%
two_apps 86.110 86.093 -0.018 -0.020%
web_worker_fib 152.255 152.225 -0.030 -0.020%
webgl 84.830 84.814 -0.016 -0.018%

✅ None of the examples has changed their size significantly.

@futursolo futursolo added bug A-yew Area: The main yew crate labels Sep 15, 2022
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@voidpumpkin voidpumpkin merged commit ce70e4c into yewstack:master Sep 15, 2022
@futursolo futursolo deleted the resume-on-unmount branch December 15, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspension not getting dropped
2 participants