Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keywords after dash in element and attribute names #2820

Merged
merged 1 commit into from Aug 8, 2022

Conversation

hamza1311
Copy link
Member

Description

Fixes #2810

Checklist

  • I have reviewed my own code
  • I have added tests

@hamza1311 hamza1311 added bug A-yew-macro Area: The yew-macro crate labels Aug 8, 2022
@hamza1311 hamza1311 added this to the v0.20 milestone Aug 8, 2022
@hamza1311 hamza1311 enabled auto-merge (squash) August 8, 2022 19:08
github-actions[bot]
github-actions bot previously approved these changes Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Visit the preview URL for this PR (updated for commit f31cedd):

https://yew-rs-api--pr2820-dashed-html-name-key-7xyjvio3.web.app

(expires Mon, 15 Aug 2022 19:16:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 345.692 348.981 346.589 0.904
Hello World 10 1067.503 1080.165 1073.922 5.040
Function Router 10 3392.639 3409.862 3403.486 4.945
Concurrent Task 10 1010.119 1011.400 1010.900 0.448

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 353.817 354.864 354.452 0.338
Hello World 10 1073.621 1085.429 1079.712 4.562
Function Router 10 3388.912 3400.849 3392.950 4.188
Concurrent Task 10 1009.420 1011.444 1010.498 0.694

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 171.785 171.790 +0.005 +0.003%
contexts 108.684 108.685 +0.001 +0.001%
counter 85.840 85.842 +0.002 +0.002%
counter_functional 86.479 86.479 -0.001 -0.001%
dyn_create_destroy_apps 89.013 89.014 +0.001 +0.001%
file_upload 101.949 101.951 +0.002 +0.002%
function_memory_game 165.635 165.596 -0.039 -0.024%
function_router 349.549 349.557 +0.008 +0.002%
function_todomvc 160.176 160.186 +0.010 +0.006%
futures 224.585 224.585 0 0.000%
game_of_life 106.301 106.302 +0.001 +0.001%
immutable 185.028 185.032 +0.004 +0.002%
inner_html 82.997 82.999 +0.002 +0.002%
js_callback 111.822 111.827 +0.005 +0.004%
keyed_list 194.443 194.445 +0.002 +0.001%
mount_point 85.489 85.490 +0.001 +0.001%
nested_list 114.849 114.851 +0.002 +0.002%
node_refs 92.889 92.891 +0.002 +0.002%
password_strength 1545.058 1545.058 0 0.000%
portals 96.646 96.645 -0.001 -0.001%
router 319.074 319.086 +0.012 +0.004%
simple_ssr 153.606 153.604 -0.002 -0.001%
ssr_router 395.554 395.522 -0.031 -0.008%
suspense 109.475 109.455 -0.020 -0.018%
timer 88.583 88.584 +0.001 +0.001%
todomvc 141.621 141.623 +0.002 +0.001%
two_apps 86.510 86.511 +0.001 +0.001%
web_worker_fib 152.938 152.947 +0.009 +0.006%
webgl 86.738 86.738 0 0.000%

✅ None of the examples has changed their size significantly.

@hamza1311 hamza1311 merged commit f640fc7 into yewstack:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-macro Area: The yew-macro crate bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"expected identifier" on "type" attribute in "html!" macro
2 participants