New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax to bind to properties instead of attributes #2819
Merged
hamza1311
merged 18 commits into
yewstack:master
from
hamza1311:properties-not-attributes
Aug 14, 2022
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
971eaa8
Set to properties, not attributes
hamza1311 2177f8c
fix tests
hamza1311 27efd0a
Add tests
hamza1311 866dbe6
enable disabled test, fmt
hamza1311 b0c0126
Introduce @key syntax to forcefully set as attribute
hamza1311 0bb8cd5
Everything compiles
hamza1311 66e714c
More tests
hamza1311 ea353cc
id as property
hamza1311 43ab9d0
This was not meant to be committed
hamza1311 9b418bf
Make test pass, fmt + clippy
hamza1311 5e8c4c4
fucking rustfmt
hamza1311 00deee5
is this enough formatting
hamza1311 0107f03
that was not supposed to be commited
hamza1311 1eea41a
apply review
hamza1311 3b9fa16
Merge branch 'master' into properties-not-attributes
hamza1311 b8cf9b8
fmt
hamza1311 ec4f599
fix CI
hamza1311 dfd2082
will you be happy now, clippy?
hamza1311 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For properties, maybe we should apply a snake_case to camelCase conversion here like
web_sys
.We only need to do this with
html!
macro as at runtime property names are set asstring
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is a good idea. We don't convert
snake_case
tokebab-case
for attributes so this will be just another differentiator between the two. We can add it for both though, but that is for a future PR