Added notes to the documentation about SVG tag casing #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza1311
previously approved these changes
May 24, 2022
|
Visit the preview URL for this PR (updated for commit a85e57f): https://yew-rs--pr2703-master-xk3913wv.web.app (expires Wed, 01 Jun 2022 10:33:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
WorldSEnder
requested changes
May 24, 2022
Co-authored-by: WorldSEnder <WorldSEnder@users.noreply.github.com>
WorldSEnder
approved these changes
May 25, 2022
hamza1311
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added notes to https://yew.rs/docs/next/concepts/html and https://yew.rs/docs/concepts/html/introduction to warn users about SVG tag casing. I also fixed an example that was broken on both pages.
Fixes #2699
Checklist
Do I need to run some sort of lint on the .mdx files I changed? I couldn't see anything in the website readme about one.