Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bubbling of events originating in user shadow dom #2627

Merged
merged 1 commit into from Apr 20, 2022

Conversation

WorldSEnder
Copy link
Member

When there is no explicit portal into the shadow, we should bubble up to the host element of the shadow root and continue. This fixes custom elements internally using open shadow DOM.

Description

Fixes #2624

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

when we not explicitly portaling into the shadow, we
should bubble up to the host element and continue.
This fixes custom elements internally using open SD
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 335783e):

https://yew-rs-api--pr2627-shadow-aware-bubblin-maon056v.web.app

(expires Wed, 27 Apr 2022 07:32:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

Size Comparison

examples master (KB) pull request (KB) diff
boids 173.225 173.419 +0.194
contexts 110.501 110.690 +0.189
counter 87.184 87.386 +0.202
counter_functional 87.746 87.943 +0.197
dyn_create_destroy_apps 90.268 90.436 +0.168
file_upload 103.117 103.317 +0.200
function_memory_game 167.623 167.814 +0.191
function_router 353.295 353.348 +0.053
function_todomvc 162.514 162.717 +0.203
futures 226.903 227.100 +0.196
game_of_life 108.204 108.423 +0.219
inner_html 83.682 83.881 +0.199
js_callback 113.266 113.459 +0.193
keyed_list 196.121 196.312 +0.191
mount_point 86.707 86.903 +0.196
nested_list 116.218 116.408 +0.190
node_refs 90.077 90.274 +0.197
password_strength 1539.661 1539.890 +0.229
portals 97.286 97.481 +0.195
router 319.138 319.216 +0.078
simple_ssr 500.580 500.780 +0.200
ssr_router 428.699 428.905 +0.206
suspense 111.021 111.217 +0.196
timer 89.899 90.103 +0.203
todomvc 143.865 144.064 +0.199
two_apps 87.772 87.970 +0.197
webgl 87.358 87.561 +0.202

@hamza1311 hamza1311 merged commit c2b2f2c into yewstack:master Apr 20, 2022
@hamza1311 hamza1311 added bug A-yew Area: The main yew crate labels Apr 20, 2022
@WorldSEnder WorldSEnder deleted the shadow-aware-bubbling branch April 20, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click handler not being triggered on custom element
2 participants