Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing of dynamic tags #2578

Merged
merged 3 commits into from Apr 5, 2022
Merged

Conversation

WorldSEnder
Copy link
Member

Description

Fixes #2483
Related #1269: I'm not sure that's fully addressed with the PR

There's a comment by @siku2 about preserving capitalization, but that doesn't seem to be what's implemented, at least not everywhere.

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

github-actions[bot]
github-actions bot previously approved these changes Apr 5, 2022
@WorldSEnder WorldSEnder added the A-yew-macro Area: The yew-macro crate label Apr 5, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Visit the preview URL for this PR (updated for commit 1e418e2):

https://yew-rs-api--pr2578-fix-tag-casing-myu7l50c.web.app

(expires Tue, 12 Apr 2022 14:25:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Size Comparison

examples master (KB) pull request (KB) diff
boids 311.361 311.361 0
contexts 232.225 232.225 0
counter 164.661 164.661 0
dyn_create_destroy_apps 172.880 172.880 0
file_upload 195.101 195.101 0
function_memory_game 349.353 349.353 0
function_router 406.764 406.764 0
function_todomvc 325.313 325.313 0
futures 362.467 362.467 0
game_of_life 207.341 207.341 0
inner_html 156.521 156.521 0
js_callback 172.026 172.026 0
keyed_list 329.185 329.185 0
mount_point 163.830 163.830 0
nested_list 225.504 225.504 0
node_refs 170.927 170.927 0
password_strength 1851.823 1851.823 0
portals 184.418 184.418 0
router 588.481 588.481 0
simple_ssr 576.700 576.700 0
ssr_router 497.603 497.603 0
suspense 221.720 221.720 0
timer 170.514 170.514 0
todomvc 270.753 270.753 0
two_apps 166.137 166.137 0
webgl 170.941 170.941 0

siku2
siku2 previously approved these changes Apr 5, 2022
@WorldSEnder WorldSEnder dismissed stale reviews from siku2 and github-actions via 1e418e2 April 5, 2022 14:21
@WorldSEnder
Copy link
Member Author

After further playing around with it, and forgetting to sometimes use the dynamic tag form, I've decided to add a lint. Only shows up on nightly, like the other lints, but I think it's better than nothing.

@WorldSEnder WorldSEnder requested a review from siku2 April 5, 2022 15:46
@siku2
Copy link
Member

siku2 commented Apr 5, 2022

After further playing around with it, and forgetting to sometimes use the dynamic tag form, I've decided to add a lint. Only shows up on nightly, like the other lints, but I think it's better than nothing.

Even better! :)

@WorldSEnder WorldSEnder merged commit 8978baa into yewstack:master Apr 5, 2022
@WorldSEnder WorldSEnder deleted the fix-tag-casing branch April 5, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-macro Area: The yew-macro crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG tags are case-sensitive, but yew lowercases them
2 participants