Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement imperative refs, capturing scopes to child components #2551

Closed
wants to merge 43 commits into from
Closed

Implement imperative refs, capturing scopes to child components #2551

wants to merge 43 commits into from

Commits on Apr 22, 2022

  1. implement imperative refs, capturing a scope 

    instead of getting a ref "the first element", now get a
Scope link to the component
alternative design, should result in smaller codesize
    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    562e879 View commit details
    Browse the repository at this point in the history

  2. documentation for ComponentRef

    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d1dd4bc View commit details
    Browse the repository at this point in the history

  3. fix doc test

    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    32dfe0d View commit details
    Browse the repository at this point in the history

  4. Fix a bunch of issues with docs

    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    ff99444 View commit details
    Browse the repository at this point in the history

  5. address review: 

    scope_ref -> comp_ref
swap_into -> morph_into, and added a test case for behaviour
remove mention of Agents and Services from docs
    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    f8b917e View commit details
    Browse the repository at this point in the history

  6. restrict new and get to struct components for now 

    they should get non-forwarding behaviour as default
avoids breaking changes when introducing refs on function
components.
    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    1f3de5d View commit details
    Browse the repository at this point in the history

  7. shift ComponentRef into inner state 

    foresight to forwardRef: will depend on impl Component in the future
    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    560e56e View commit details
    Browse the repository at this point in the history

  8. rename ComponentAnyRef 

    Erased better represents internal character
    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    7ecb58f View commit details
    Browse the repository at this point in the history

  9. fixup linting

    @WorldSEnder
    WorldSEnder committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    fc563ad View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. implement HtmlRef 

    the internally used NodeRef is now called DomPosition
a new associated type on BaseComponent specifies the bound ref
forwardRef and other advanced concepts are not part of this
    @WorldSEnder
    WorldSEnder committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    7070025 View commit details
    Browse the repository at this point in the history

  2. commit to changed macro errors

    @WorldSEnder
    WorldSEnder committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    08fb45e View commit details
    Browse the repository at this point in the history

  3. commit the component ref immdiately after view 

    makes the ref available to the create lifecycle of children
    @WorldSEnder
    WorldSEnder committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    f1908f4 View commit details
    Browse the repository at this point in the history

  4. make the reference bindable

    @WorldSEnder
    WorldSEnder committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    39492bf View commit details
    Browse the repository at this point in the history

  5. some code size optimizations

    @WorldSEnder
    WorldSEnder committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    3e3c674 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Merge remote-tracking branch 'upstream/master' into imperative-ref

    @WorldSEnder
    WorldSEnder committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    00a2e0b View commit details
    Browse the repository at this point in the history

  2. fix doc test

    @WorldSEnder
    WorldSEnder committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    0a4a2ee View commit details
    Browse the repository at this point in the history

  3. fix website tests

    @WorldSEnder
    WorldSEnder committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    d5684bc View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. the ref is now bound in BaseComponent::create

    @WorldSEnder
    WorldSEnder committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    0a05ffc View commit details
    Browse the repository at this point in the history

  2. remove dyn Debug of user binds, saves space

    @WorldSEnder
    WorldSEnder committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    58087d5 View commit details
    Browse the repository at this point in the history

  3. fixup website tests

    @WorldSEnder
    WorldSEnder committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    c2785c7 View commit details
    Browse the repository at this point in the history

  4. feature soundness, apparently

    @WorldSEnder
    WorldSEnder committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    fc753ba View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. re-expose event log for debugging

    @WorldSEnder
    WorldSEnder committed May 4, 2022
    Configuration menu
    Copy the full SHA
    9eb2edf View commit details
    Browse the repository at this point in the history

  2. add default fn to BaseComponent

    @WorldSEnder
    WorldSEnder committed May 4, 2022
    Configuration menu
    Copy the full SHA
    b857074 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into imperative-ref

    @WorldSEnder
    WorldSEnder committed May 4, 2022
    Configuration menu
    Copy the full SHA
    56fa37d View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. introduce intermediate trait ComponentWithRef

    @WorldSEnder
    WorldSEnder committed May 6, 2022
    Configuration menu
    Copy the full SHA
    cbf0dd7 View commit details
    Browse the repository at this point in the history

  2. pass BindableRef to FunctionComponent

    @WorldSEnder
    WorldSEnder committed May 6, 2022
    Configuration menu
    Copy the full SHA
    da0c131 View commit details
    Browse the repository at this point in the history

  3. introduce explicit ErasedHtmlRef::unbound 

    E*Ref::unbound is used when no user ref is given
    @WorldSEnder
    WorldSEnder committed May 6, 2022
    Configuration menu
    Copy the full SHA
    4bf5e23 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. convert light_switch to example

    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    7698970 View commit details
    Browse the repository at this point in the history

  2. assert that ref is set in debug mode

    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    cbad47b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into imperative-ref

    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    6c3d655 View commit details
    Browse the repository at this point in the history

  4. inch towards imperative ref on function comps

    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    f229c62 View commit details
    Browse the repository at this point in the history

  5. remove ErasedStorage

    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b104b58 View commit details
    Browse the repository at this point in the history

  6. NoReference is now an empty enum 

    truly has no values for stronger guarantees
    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    895ce20 View commit details
    Browse the repository at this point in the history

  7. fix website link

    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    8e77558 View commit details
    Browse the repository at this point in the history

  8. Rc<Setter> -> Setter 

    just one method to monomorphize, not closures thereof
    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    22e6db5 View commit details
    Browse the repository at this point in the history

  9. readability, use CompRef

    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    6f9590d View commit details
    Browse the repository at this point in the history

  10. move erased_ref to ComponentState

    @WorldSEnder
    WorldSEnder committed May 14, 2022
    Configuration menu
    Copy the full SHA
    afcbeb2 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. fix feature linting

    @WorldSEnder
    WorldSEnder committed May 15, 2022
    Configuration menu
    Copy the full SHA
    5dd862a View commit details
    Browse the repository at this point in the history

  2. omit a drop impl 

    this should shave some size from BaseComponent::create
    @WorldSEnder
    WorldSEnder committed May 15, 2022
    Configuration menu
    Copy the full SHA
    9deac03 View commit details
    Browse the repository at this point in the history

  3. adjust documentation

    @WorldSEnder
    WorldSEnder committed May 15, 2022
    Configuration menu
    Copy the full SHA
    cbabe59 View commit details
    Browse the repository at this point in the history

  4. move node erasure to construction

    @WorldSEnder
    WorldSEnder committed May 15, 2022
    Configuration menu
    Copy the full SHA
    258cc3a View commit details
    Browse the repository at this point in the history

  5. fixup of previous 2 commits

    @WorldSEnder
    WorldSEnder committed May 15, 2022
    Configuration menu
    Copy the full SHA
    42e1a0c View commit details
    Browse the repository at this point in the history

  6. fix doc test in website-docs

    @WorldSEnder
    WorldSEnder committed May 15, 2022
    Configuration menu
    Copy the full SHA
    3eeae19 View commit details
    Browse the repository at this point in the history