Fix examples #1093
Merged
Fix examples #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using examples/showcase masked breakages in multiple examples.
|
Thank you! I was in the process of fixing this too 😅 |
|
You are welcome. This change causes travis to run approximately 2x longer, 31m compared to the last successful pull request (#1085) which was 16m. Is that acceptable? |
|
@wathiede not ideal, I'll follow up with a fix for the long build times :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of examples were broken by "Make Component::change impl mandatory #1071", so I fixed them and changed the CI check so they wouldn't be missed in the future.