Fix errors in the TwoApps showcase example #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4d5227 changed the name of `Msg::SetScope` to `Msg::SetOpposite` but the usages in the `main` functions of the `two_apps` examples were not updated.
`TwoModels` is a `Component` that does not respond to changes but which creates two instances of the `Model` and mounts them as separate `yew::App<Model>` instances in the body. This is done to mimic the behavior of `two_apps/src/main.rs` which uses a static `index.html` file containing the `div.first-app` and `div.second-app` elements. `TwoModels::mounted` is responsible for replacing the `<div>` nodes it creates during the initial render with the `Model` components.
|
I was not able to reproduce the errors described in the other showcase examples in my local testing. I suspect that #1071 cleared up the error with the LargeTable example. GameOfLife did not panic for me while running (though it's possible I didn't use the correct settings or let it run long enough). NpmAndRest successfully completed both requests. |
|
Wow, you just knocked out a 2 year old issue! Thanks so much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "two apps" part of the
two_appsexample is now implemented in bothtwo_apps/src/main.rsand in theTwoModelscomponent oftwo_apps/src/lib.rs. TheTwoModels::mountedimplementation mimics the work done inmain.rsof the example. TheTwoModelsstruct and implementation are the same in both theweb_sysandstd_webexamples.Fixes #201