Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Yew 0.20 #2973

Merged
merged 12 commits into from Nov 25, 2022
Merged

Prepare for Yew 0.20 #2973

merged 12 commits into from Nov 25, 2022

Conversation

hamza1311
Copy link
Member

Description

Prepare for 0.20 release. This PR updates the change log (and the generator) and also adds a blog post to along with the release.

Closes #2753

Checklist

  • I have reviewed my own code
  • I have added tests

@hamza1311 hamza1311 added this to the v0.20 milestone Nov 23, 2022
@hamza1311 hamza1311 requested a review from a team November 23, 2022 19:06
github-actions[bot]
github-actions bot previously approved these changes Nov 23, 2022
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple typos, otherwise looks good.

website/blog/2022-11-24-release-0-20.md Outdated Show resolved Hide resolved
website/blog/2022-11-24-release-0-20.md Outdated Show resolved Hide resolved
WorldSEnder
WorldSEnder previously approved these changes Nov 24, 2022
Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for doing the final push. As you said, the release is overdue and I think a great lot will enjoy having the newly added features in a release version. 🎉 Couple of typos spotted ;)

website/blog/2022-11-24-release-0-20.md Outdated Show resolved Hide resolved
website/blog/2022-11-24-release-0-20.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
- Convert nightly from a feature flag to a compiler flag. [[@Muhammad Hamza](https://github.com/Muhammad Hamza), [#2827](https://github.com/yewstack/yew/pull/2827)]
- Reduce SSR Buffers in VList. [[@Kaede Hoshikawa](https://github.com/Kaede Hoshikawa), [#2826](https://github.com/yewstack/yew/pull/2826)]
- Allow keywords after dash in element and attribute names. [[@Muhammad Hamza](https://github.com/Muhammad Hamza), [#2820](https://github.com/yewstack/yew/pull/2820)]
- onsubmit should be a SubmitEvent. [[@Muhammad Hamza](https://github.com/Muhammad Hamza), [#2816](https://github.com/yewstack/yew/pull/2816)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been in the "Fixes" section.

CHANGELOG.md Outdated
- Redo derive(Properties), take 2. [[@WorldSEnder](https://github.com/WorldSEnder), [#2729](https://github.com/yewstack/yew/pull/2729)]
- `Callback::reform()` should return `Callback<T, OUT>`. [[@orzogc](https://github.com/orzogc), [#2719](https://github.com/yewstack/yew/pull/2719)]
- Span hygiene and editor UX. [[@WorldSEnder](https://github.com/WorldSEnder), [#2702](https://github.com/yewstack/yew/pull/2702)]
- Partially undo #2673, different approach for the DerefMut impl of VList. [[@WorldSEnder](https://github.com/WorldSEnder), [#2692](https://github.com/yewstack/yew/pull/2692)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be moved under the mentioned PR, for clarity.

- Span hygiene and editor UX. [[@WorldSEnder](https://github.com/WorldSEnder), [#2702](https://github.com/yewstack/yew/pull/2702)]
- Partially undo #2673, different approach for the DerefMut impl of VList. [[@WorldSEnder](https://github.com/WorldSEnder), [#2692](https://github.com/yewstack/yew/pull/2692)]
- `use_prepared_state` & `use_transitive_state`. [[@Kaede Hoshikawa](https://github.com/Kaede Hoshikawa), [#2650](https://github.com/yewstack/yew/pull/2650)]
- Block props update during hydration. [[@Kaede Hoshikawa](https://github.com/Kaede Hoshikawa), [#2665](https://github.com/yewstack/yew/pull/2665)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also more of a fix, instead of a feature.

CHANGELOG.md Outdated
- constify VList::new. [[@Alexander Mescheryakov](https://github.com/Alexander Mescheryakov), [#2293](https://github.com/yewstack/yew/pull/2293)]
- Allow `function_component` creation based on function name. [[@Muhammad Hamza](https://github.com/Muhammad Hamza), [#2292](https://github.com/yewstack/yew/pull/2292)]
- Implement IntoPropValue for Rc<str>. [[@Zachary Stewart](https://github.com/Zachary Stewart), [#2285](https://github.com/yewstack/yew/pull/2285)]
- Silence some warnings from derive(Properties). [[@WorldSEnder](https://github.com/WorldSEnder), [#2266](https://github.com/yewstack/yew/pull/2266)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also more of a "fix".

CHANGELOG.md Show resolved Hide resolved
Co-authored-by: WorldSEnder <WorldSEnder@users.noreply.github.com>
Co-authored-by: Julius Lungys <32368314+voidpumpkin@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Nov 24, 2022
github-actions[bot]
github-actions bot previously approved these changes Nov 24, 2022
@github-actions
Copy link

github-actions bot commented Nov 24, 2022

Visit the preview URL for this PR (updated for commit b2713ed):

https://yew-rs--pr2973-0-20-changelog-mfwb43zw.web.app

(expires Thu, 01 Dec 2022 15:10:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot]
github-actions bot previously approved these changes Nov 24, 2022
@github-actions
Copy link

github-actions bot commented Nov 24, 2022

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 293.719 338.681 301.615 13.132
Hello World 10 559.036 641.676 572.855 24.352
Function Router 10 1955.985 2234.887 1998.579 83.738
Concurrent Task 10 1007.494 1009.655 1008.523 0.666

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 296.669 337.152 305.193 16.476
Hello World 10 552.515 625.999 567.492 30.550
Function Router 10 1983.745 2256.741 2043.275 112.313
Concurrent Task 10 1007.356 1009.587 1008.420 0.617

github-actions[bot]
github-actions bot previously approved these changes Nov 24, 2022
@github-actions
Copy link

github-actions bot commented Nov 24, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 108.397 108.397 0 0.000%
boids 172.640 172.646 +0.006 +0.003%
communication_child_to_parent 92.438 92.439 +0.002 +0.002%
communication_grandchild_with_grandparent 106.945 106.952 +0.007 +0.006%
communication_grandparent_to_grandchild 102.787 102.786 -0.001 -0.001%
communication_parent_to_child 89.531 89.523 -0.008 -0.009%
contexts 109.507 109.500 -0.007 -0.006%
counter 87.448 87.446 -0.002 -0.002%
counter_functional 87.862 87.862 0 0.000%
dyn_create_destroy_apps 90.296 90.292 -0.004 -0.004%
file_upload 101.767 101.765 -0.002 -0.002%
function_memory_game 165.378 165.367 -0.011 -0.006%
function_router 350.290 350.296 +0.006 +0.002%
function_todomvc 160.100 160.107 +0.008 +0.005%
futures 224.776 224.777 +0.001 +0.000%
game_of_life 107.217 107.217 0 0.000%
immutable 184.452 184.453 +0.001 +0.001%
inner_html 83.862 83.864 +0.002 +0.002%
js_callback 113.157 113.158 +0.001 +0.001%
keyed_list 197.916 197.918 +0.002 +0.001%
mount_point 87.012 87.013 +0.001 +0.001%
nested_list 114.047 114.042 -0.005 -0.004%
node_refs 94.953 94.952 -0.001 -0.001%
password_strength 1553.920 1553.921 +0.001 +0.000%
portals 98.252 98.252 0 0.000%
router 320.456 320.457 +0.001 +0.000%
simple_ssr 153.452 153.451 -0.001 -0.001%
ssr_router 395.074 395.075 +0.001 +0.000%
suspense 110.771 110.772 +0.002 +0.002%
timer 90.340 90.341 +0.001 +0.001%
todomvc 141.376 141.377 +0.001 +0.001%
two_apps 88.067 88.067 0 0.000%
web_worker_fib 154.435 154.449 +0.015 +0.009%
webgl 86.562 86.563 +0.001 +0.001%

✅ None of the examples has changed their size significantly.

@hamza1311 hamza1311 merged commit f0209c7 into yewstack:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for yew 0.20
3 participants