Make Component::change impl mandatory

yewstack · Apr 4, 2020 · ef90ff4 · ef90ff4
1 parent 039c860
commit ef90ff4
Show file tree

Hide file tree

Showing 38 changed files with 368 additions and 142 deletions.
diff --git a/crates/macro/src/lib.rs b/crates/macro/src/lib.rs
@@ -31,6 +31,10 @@
 //! #         unimplemented!()
 //! #     }
 //! #
+//! #     fn change(&mut self, props: Self::Properties) -> ShouldRender {
+//! #         unimplemented!()
+//! #     }
+//! #
 //! #     fn view(&self) -> Html {
 //! #
 //! // ...

diff --git a/crates/macro/tests/macro/html-component-fail.rs b/crates/macro/tests/macro/html-component-fail.rs
@@ -21,6 +21,9 @@ impl Component for Child {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }
@@ -42,6 +45,9 @@ impl Component for ChildContainer {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }
@@ -61,6 +67,9 @@ impl Component for Generic<String> {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }

diff --git a/crates/macro/tests/macro/html-component-fail.stderr b/crates/macro/tests/macro/html-component-fail.stderr
diff --git a/crates/macro/tests/macro/html-component-pass.rs b/crates/macro/tests/macro/html-component-pass.rs
@@ -19,6 +19,9 @@ impl Component for Generic<String> {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }
@@ -34,6 +37,9 @@ impl Component for Generic<Vec<String>> {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }
@@ -57,6 +63,9 @@ impl Component for Container {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }
@@ -113,6 +122,9 @@ impl Component for Child {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }
@@ -129,6 +141,9 @@ impl Component for AltChild {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }
@@ -152,6 +167,9 @@ impl Component for ChildContainer {
     fn update(&mut self, _: Self::Message) -> ShouldRender {
         unimplemented!()
     }
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        unimplemented!()
+    }
     fn view(&self) -> Html {
         unimplemented!()
     }

diff --git a/examples/crm/src/lib.rs b/examples/crm/src/lib.rs
@@ -146,6 +146,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         match self.scene {
             Scene::ClientsList => html! {

diff --git a/examples/custom_components/src/lib.rs b/examples/custom_components/src/lib.rs
@@ -46,6 +46,10 @@ impl Component for Model {
         }
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         let counter = |x| {
             html! {

diff --git a/examples/dashboard/src/lib.rs b/examples/dashboard/src/lib.rs
@@ -186,6 +186,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/examples/fragments/src/lib.rs b/examples/fragments/src/lib.rs
@@ -34,6 +34,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <>

diff --git a/examples/game_of_life/src/lib.rs b/examples/game_of_life/src/lib.rs
@@ -209,6 +209,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/examples/large_table/src/lib.rs b/examples/large_table/src/lib.rs
@@ -33,6 +33,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <table>

diff --git a/examples/showcase/src/main.rs b/examples/showcase/src/main.rs
@@ -91,6 +91,10 @@ impl Component for Model {
         }
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div id="fullscreen">

diff --git a/examples/std_web/counter/src/lib.rs b/examples/std_web/counter/src/lib.rs
@@ -48,6 +48,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/examples/std_web/inner_html/src/lib.rs b/examples/std_web/inner_html/src/lib.rs
@@ -33,6 +33,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         let js_svg = js! {
             var div = document.createElement("div");

diff --git a/examples/std_web/mount_point/src/lib.rs b/examples/std_web/mount_point/src/lib.rs
@@ -29,6 +29,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/examples/std_web/node_refs/src/input.rs b/examples/std_web/node_refs/src/input.rs
@@ -31,6 +31,11 @@ impl Component for InputComponent {
         false
     }
 
+    fn change(&mut self, props: Self::Properties) -> ShouldRender {
+        self.props = props;
+        true
+    }
+
     fn view(&self) -> Html {
         html! {
             <input

diff --git a/examples/std_web/node_refs/src/lib.rs b/examples/std_web/node_refs/src/lib.rs
@@ -46,6 +46,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div class="main">

diff --git a/examples/std_web/npm_and_rest/src/lib.rs b/examples/std_web/npm_and_rest/src/lib.rs
@@ -67,6 +67,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         let view_exchange = |exchange| {
             html! {

diff --git a/examples/std_web/todomvc/src/lib.rs b/examples/std_web/todomvc/src/lib.rs
@@ -121,6 +121,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div class="todomvc-wrapper">

diff --git a/examples/std_web/two_apps/src/lib.rs b/examples/std_web/two_apps/src/lib.rs
@@ -57,6 +57,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/examples/textarea/src/lib.rs b/examples/textarea/src/lib.rs
@@ -35,6 +35,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/examples/timer/src/lib.rs b/examples/timer/src/lib.rs
@@ -97,6 +97,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         let view_message = |message| {
             html! { <p>{ message }</p> }

diff --git a/examples/web_sys/counter/src/lib.rs b/examples/web_sys/counter/src/lib.rs
@@ -48,6 +48,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/examples/web_sys/inner_html/src/lib.rs b/examples/web_sys/inner_html/src/lib.rs
@@ -30,6 +30,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         let js_svg = {
             let div = web_sys::window()

diff --git a/examples/web_sys/mount_point/src/lib.rs b/examples/web_sys/mount_point/src/lib.rs
@@ -29,6 +29,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/examples/web_sys/node_refs/src/input.rs b/examples/web_sys/node_refs/src/input.rs
@@ -31,6 +31,11 @@ impl Component for InputComponent {
         false
     }
 
+    fn change(&mut self, props: Self::Properties) -> ShouldRender {
+        self.props = props;
+        true
+    }
+
     fn view(&self) -> Html {
         html! {
             <input

diff --git a/examples/web_sys/node_refs/src/lib.rs b/examples/web_sys/node_refs/src/lib.rs
@@ -45,6 +45,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div class="main">

diff --git a/examples/web_sys/npm_and_rest/src/lib.rs b/examples/web_sys/npm_and_rest/src/lib.rs
@@ -64,6 +64,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         let view_exchange = |exchange| {
             html! {

diff --git a/examples/web_sys/todomvc/src/lib.rs b/examples/web_sys/todomvc/src/lib.rs
@@ -121,6 +121,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div class="todomvc-wrapper">

diff --git a/examples/web_sys/two_apps/src/lib.rs b/examples/web_sys/two_apps/src/lib.rs
@@ -57,6 +57,10 @@ impl Component for Model {
         true
     }
 
+    fn change(&mut self, _: Self::Properties) -> ShouldRender {
+        false
+    }
+
     fn view(&self) -> Html {
         html! {
             <div>

diff --git a/src/components/select.rs b/src/components/select.rs
@@ -14,6 +14,7 @@
 //!#     type Message = ();type Properties = ();
 //!#     fn create(props: Self::Properties,link: ComponentLink<Self>) -> Self {unimplemented!()}
 //!#     fn update(&mut self,msg: Self::Message) -> bool {unimplemented!()}
+//!#     fn change(&mut self, _: Self::Properties) -> bool {unimplemented!()}
 //!#     fn view(&self) -> Html {unimplemented!()}}
 //! impl ToString for Scene {
 //!     fn to_string(&self) -> String {