#1276, Refactor AsyncBatchDestroyJob to increase efficiency #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ivanov-Anton I am not sure this is good idea. From my point of view we should not allow deletion of used numberlist. |
|
I think we need some validation to fix #1276 |
…y and resilience The AsyncBatchDestroyJob has been refactored to utilise Rails's `find_in_batches` method as opposed to a custom SQL query. This proves to make the process of record deletion both more efficient and more resilient to database inconsistencies. Previously, records that could not be deleted due to dependencies would raise an exception, breaking the whole transaction. Now, these records are logged and skipped over instead. Updates to associated tests have been made to verify and reflect these changes.
Ivanov-Anton
force-pushed
the
YETIWEB-1276-Bacth-actions-job-validations-for-numberlists
branch
from
6a39019
to
5b24d6c
Compare
Ivanov-Anton
changed the title
Ivanov-Anton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The AsyncBatchDestroyJob has been refactored to utilise Rails's
find_in_batchesmethod as opposed to a custom SQL query. This proves to make the process of record
deletion both more efficient and more resilient to database inconsistencies.
Previously, records that could not be deleted due to dependencies would raise an
exception, breaking the whole transaction. Now, these records are logged and
skipped over instead. Updates to associated tests have been made to verify and
reflect these changes.
Additional links
closes #1276