Merge pull request #1150 from senid231/fix-deserialization-error-duri…

…ng-send-sentry-event Use recommended sentry send mechanism
yeti-switch · Jun 27, 2022 · 98fe34f · 98fe34f
2 parents 34dc23c + b81e213
commit 98fe34f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 21 deletions.
diff --git a/app/jobs/worker/capture_error_job.rb b/app/jobs/worker/capture_error_job.rb
diff --git a/lib/capture_error.rb b/lib/capture_error.rb
@@ -41,7 +41,10 @@ def configure!
           event
         }
 
-        sentry_config.async = ->(event, hint = nil) { Worker::CaptureErrorJob.perform_later(event, hint) }
+        # Usage of an async option is discouraged by sentry-ruby developers.
+        # By default sentry will create its own background workers to send sentry events.
+        # See https://github.com/getsentry/sentry-ruby/issues/1522
+        # and https://docs.sentry.io/platforms/ruby/configuration/options/#optional-settings
         sentry_config.send_default_pii = true
         sentry_config.breadcrumbs_logger = %i[sentry_logger active_support_logger]
         sentry_config.project_root = Rails.root.to_s