Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pre-commit versions #614

Merged
merged 1 commit into from Nov 29, 2020
Merged

Conversation

MarcoGorelli
Copy link
Contributor

Hi 👋

using rev: stable will raise a warning in pre-commit (see pre-commit/pre-commit#974) so here's a PR to pin it to a tag (as well as to pin the version for nbqa)

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #614 (42d7490) into develop (8b185ab) will increase coverage by 0.44%.
The diff coverage is 98.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #614      +/-   ##
===========================================
+ Coverage    87.95%   88.40%   +0.44%     
===========================================
  Files          122      124       +2     
  Lines         3164     3216      +52     
===========================================
+ Hits          2783     2843      +60     
+ Misses         381      373       -8     
Flag Coverage Δ
examples 31.14% <16.21%> (+0.08%) ⬆️
issue 77.83% <96.42%> (+0.76%) ⬆️
unit 85.32% <97.56%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
src/pandas_profiling/config.py 95.16% <ø> (ø)
src/pandas_profiling/controller/console.py 96.15% <ø> (ø)
src/pandas_profiling/model/correlations.py 86.45% <ø> (ø)
src/pandas_profiling/model/describe.py 97.05% <ø> (ø)
src/pandas_profiling/profile_report.py 78.90% <ø> (+1.63%) ⬆️
...profiling/report/presentation/flavours/__init__.py 100.00% <ø> (ø)
...profiling/report/presentation/flavours/flavours.py 72.72% <ø> (+12.72%) ⬆️
src/pandas_profiling/report/structure/report.py 94.62% <ø> (ø)
...iling/report/structure/variables/render_boolean.py 100.00% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0d0e4...42d7490. Read the comment docs.

@sbrugman
Copy link
Collaborator

Thanks for pointing this out, happy to merge.

For some reason the test is failing in this job (probably not related to this PR). Nevertheless I'd like to understand at least why it's failing before merging. Restarted the test to verify.

https://travis-ci.com/github/pandas-profiling/pandas-profiling/jobs/431420212

@sbrugman sbrugman closed this Nov 19, 2020
@sbrugman sbrugman reopened this Nov 19, 2020
@sbrugman
Copy link
Collaborator

Sorry - didn't mean to close.

@sbrugman sbrugman merged commit 04697f7 into ydataai:develop Nov 29, 2020
@MarcoGorelli MarcoGorelli deleted the bump-pre-commit branch November 29, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants