[Fix rubocop#10902] Fix an error for Style/RedundantRegexpEscape st…

…ring with invalid byte sequence in UTF-8 Fixed: rubocop#10902
ydah · Jun 12, 2023 · 7c51895 · 7c51895
1 parent 664bd71
commit 7c51895
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/changelog/fix_fix_an_error_for_style_redundant_regexp_escape.md b/changelog/fix_fix_an_error_for_style_redundant_regexp_escape.md
@@ -0,0 +1 @@
+* [#10902](https://github.com/rubocop/rubocop/issues/10902): Fix an error for `Style/RedundantRegexpEscape` string with invalid byte sequence in UTF-8. ([@ydah][])
diff --git a/lib/rubocop/cop/style/redundant_regexp_escape.rb b/lib/rubocop/cop/style/redundant_regexp_escape.rb
@@ -44,7 +44,8 @@ class RedundantRegexpEscape < Base
 
         def on_regexp(node)
           each_escape(node) do |char, index, within_character_class|
-            next if allowed_escape?(node, char, index, within_character_class)
+            next if char.valid_encoding? && allowed_escape?(node, char, index,
+                                                            within_character_class)
 
             location = escape_range_at_index(node, index)
 

diff --git a/spec/rubocop/cop/style/redundant_regexp_escape_spec.rb b/spec/rubocop/cop/style/redundant_regexp_escape_spec.rb
@@ -617,4 +617,17 @@
       RUBY
     end
   end
+
+  context 'with escaping invalid byte sequence in UTF-8' do
+    it 'registers an offense and corrects' do
+      expect_offense(<<~'RUBY')
+        r = /[\§]/
+              ^^ Redundant escape inside regexp literal
+      RUBY
+
+      expect_correction(<<~RUBY)
+        r = /[§]/
+      RUBY
+    end
+  end
 end