Make Style/CollectionMethods aware of collect_concat

This PR makes `Style/CollectionMethods` aware of `collect_concat` because matches the existing `map` and `collect` terminology selection.
ydah · Sep 11, 2023 · 70fd319 · 70fd319
1 parent 3dda01c
commit 70fd319
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/changelog/change_make_style_collection_methods_aware_of_collect_concat.md b/changelog/change_make_style_collection_methods_aware_of_collect_concat.md
@@ -0,0 +1 @@
+* [#12197](https://github.com/rubocop/rubocop/pull/12197): Make `Style/CollectionMethods` aware of `collect_concat`. ([@koic][])
diff --git a/config/default.yml b/config/default.yml
@@ -3409,6 +3409,7 @@ Style/CollectionMethods:
   PreferredMethods:
     collect: 'map'
     collect!: 'map!'
+    collect_concat: 'flat_map'
     inject: 'reduce'
     detect: 'find'
     find_all: 'select'

diff --git a/lib/rubocop/cop/style/collection_methods.rb b/lib/rubocop/cop/style/collection_methods.rb
@@ -25,6 +25,7 @@ module Style
       #   # bad
       #   items.collect
       #   items.collect!
+      #   items.collect_concat
       #   items.inject
       #   items.detect
       #   items.find_all
@@ -33,6 +34,7 @@ module Style
       #   # good
       #   items.map
       #   items.map!
+      #   items.flat_map
       #   items.reduce
       #   items.find
       #   items.select