Breaking: Make navi more compatible with Ember 3.x apps #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we break this into multiple commits? |
mtgraham
force-pushed
the
fix-for-3.8-apps
branch
from
0baf0f9
to
fc4fb5f
Compare
|
@jkusa Done |
jkusa
approved these changes
Feb 21, 2019
cythrawll
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic segments of the routes should be in snake case for Ember 3.
Also there was an issue with setting the report state. The issue is that the contract for the
transition.sendfunction changed. The first argument in the function definition isignoreFailurewhich used to be defined as a boolean. So I think since we were callingtransition.sendand passing a string as the first argument, the compiler would know that the string wasn't meant to be assigned toignoreFailure. There was a change recently that no longer definesignoreFailureas a boolean, but gives it a default value offalse. Now that means that when we pass a string as the first argument, that string gets passed asignoreFailuretotransition.sendand everything blows up. The issue I mentioned says that they solved the issue by bumping up the version ofrouter_js, but the line still has the default value and not a boolean specified like it did before. So for now, we will passfalseas the first parameter totransition.send.