Adds support for --ignore-cpu in yarn install #8381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When cross-compiling a project for a different CPU architecture, e.g. for arm on a x64 machine, the only option to install arch-specific packages is to pass
--ignore-platform. But that flag also triggers installation of platform-restricted packages not intended to be used on the current platform. Since such packages are always optional their build failures are ignored, but it would be better to not build them at all.Let's add a new command line flag
--ignore-cputo ignore "cpu" restrictions in package.json,but preserve behaviour of
--ignore-platformto ignore both "cpu" and "os".To avoid merge conflicts CHANGELOG.md will be updated after the feature is approved by maintainers.
Test plan
Existing tests are updated and new ones are added.