Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an E2E test for TypeScript ESLint #669

Merged
merged 5 commits into from Jan 15, 2020
Merged

Adds an E2E test for TypeScript ESLint #669

merged 5 commits into from Jan 15, 2020

Conversation

SamChou19815
Copy link
Contributor

What's the problem this PR addresses?

#368 - Adding one basic test for ESLint with typescript-eslint

SamChou19815 and others added 2 commits January 7, 2020 12:19
**What's the problem this PR addresses?**

#368 - Adding one basic test for ESLint with `typescript-eslint`
@arcanis
Copy link
Member

arcanis commented Jan 13, 2020

Looks good, thanks! I'll just move it to the regular ESLint workflow file so as not to increase too much the number of E2E workflows (I'd like to keep one file per tool as much as possible) 👍

@SamChou19815
Copy link
Contributor Author

@arcanis I added source scripts/e2e-setup-ci.sh to the typescript-eslint step and it's now passing.
I guess the temporary directory created int he e2e setup script helps. Without this line, the integration test is directly run inside the repo root folder, and the cache in the repo folder might interfere with the test.

@arcanis
Copy link
Member

arcanis commented Jan 15, 2020

Well spotted 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants