New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete global folder in benchmarks #5523

Merged

arcanis merged 1 commit into master from merceyz/chore/benchmark-clear-global-folder

Jun 24, 2023

Member

merceyz commented Jun 24, 2023 •

edited

What's the problem this PR addresses?

07b4ceb changed the metadata cache structure but didn't update the benchmark script to match.
We're not removing the $globalFolder/index folder so install-full-cold is skipping some work.

Follow-up to #5491

How did you fix it?

Clear the entire global folder.

Checklist

I have read the Contributing Guide.
I have set the packages that need to be released for my changes to be effective.
I will check that all automated PR checks pass before the PR gets reviewed.


          chore: clear entire global folder for benchmark

eae2663

merceyz changed the title ~~chore: clear entire global folder for benchmark~~ chore: delete global folder in benchmarks

arcanis merged commit e3a567a into master

16 of 17 checks passed

arcanis deleted the merceyz/chore/benchmark-clear-global-folder branch

June 24, 2023 14:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment