Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pnp): esm - correct named commonjs imports regression #4739

Merged
merged 1 commit into from
Aug 12, 2022
Merged

fix(pnp): esm - correct named commonjs imports regression #4739

merged 1 commit into from
Aug 12, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Aug 12, 2022

What's the problem this PR addresses?

Named CommonJS imports from ESM regressed in #4737.

How did you fix it?

Correct the check and restore one of the tests I removed in #3667.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner August 12, 2022 11:47
@arcanis arcanis merged commit 68bc7e6 into master Aug 12, 2022
@arcanis arcanis deleted the merceyz/test/esm-named-cjs branch August 12, 2022 12:48
merceyz added a commit that referenced this pull request Aug 19, 2022
@merceyz
fix(pnp): esm - correct named commonjs imports regression (#4739)
5de0763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcanis arcanis Awaiting requested review from arcanis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@merceyz @arcanis