fix(pnp): esm - handle symlinked extensionless entrypoints #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
merceyz
force-pushed
the
merceyz/fix/pnp-cjs-symlink-entrypoint
branch
from
7ca00ec
to
53b354c
Compare
merceyz
force-pushed
the
merceyz/fix/pnp-cjs-symlink-entrypoint
branch
from
53b354c
to
0764215
Compare
arcanis
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The way the PnP ESM loader checks if a file is the entrypoint doesn't work with symlinks.
Fixes #3900
Closes #4282
How did you fix it?
Save the resolved entrypoint path and compare against that instead of
process.argv[1]Checklist