Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for jest #396

Merged
merged 4 commits into from Aug 26, 2019
Merged

Add e2e test for jest #396

merged 4 commits into from Aug 26, 2019

Conversation

willgriffiths
Copy link
Contributor

@willgriffiths willgriffiths commented Aug 26, 2019

What's the problem this PR addresses?

#368 Add E2E test for Jest

@arcanis
Copy link
Member

arcanis commented Aug 26, 2019

Sounds good, thanks! Can you just add a test that uses another package, to ensure that the resolution always works? Just a test to ensure that left-pad exports a function, for example.

@arcanis arcanis merged commit 7244212 into yarnpkg:master Aug 26, 2019
@arcanis
Copy link
Member

arcanis commented Aug 26, 2019

Awesome 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants