Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nm): Disallow overwriting workspace dependencies with portal dependencies #3590

Merged
merged 2 commits into from Oct 19, 2021

Conversation

larixer
Copy link
Member

@larixer larixer commented Oct 19, 2021

What's the problem this PR addresses?

This is a follow-up PR to #3438. There might be a problem when both workspace and portal are pointing to the same location. In this case, the ambiguity for the nm linker occurs, which one to use. It should give priority to a workspace because devDependencies will not be installed for portal:

How did you fix it?

When two locators point to the same soft location, I give priority to the workspace locator.

The problem was discovered by: @missing1984

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@larixer larixer changed the title fix(nm): Disallow overwriting workspaces with portals fix(nm): Disallow overwriting workspace dependencies with portal dependencies Oct 19, 2021
@arcanis arcanis merged commit ff39e53 into master Oct 19, 2021
@arcanis arcanis deleted the larixer/disallow-workspace-overwrite branch October 19, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants