Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): don't resolve missing modules to a file with the same name #3455

Merged
merged 5 commits into from Sep 17, 2021

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Sep 16, 2021

What's the problem this PR addresses?

The fix I wrote in #1464 to resolve #897 solved the reported issue but introduced other problems by resolving missing modules to a file with the same name located next to the issuer.

Fixes babel/babel#13140 (comment) (cc @nicolo-ribaudo)

How did you fix it?

When unable to resolve a dependency using PnP use resolve's default logic

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 5f123d0 into master Sep 17, 2021
@arcanis arcanis deleted the merceyz/fix/resolve-patch branch September 17, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Yarn v2 - resolve package patching breaking change
2 participants