ci: add gulp e2e test #3318
Merged
ci: add gulp e2e test #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an E2E test for coverage and validation that Yarn berry is able to install gulp successfully and then verify it can be used successfully. After installing gulp, a simple script is added to create a default gulp task that prints a statement. Running the gulp command runs the task, making sure the bare basic functionality is able to run. Then, in order to make sure that we are able to import and use the gulp api, a test is used to use the src function from gulp to load the script file that's running. Also, it makes sure we can use gulp with a specific task name as well. This should be a start to verifying gulp is installable with yarn and working as intended.
|
Ref gulpjs/gulp#2621 |
merceyz
changed the title
|
Nice, thanks! Interestingly the test seems to pass, unlike what gulpjs/gulp#2621 suggests 🤔 cc @bhanubais |
Adds badge to display the status of Gulp E2E tests to the ReadMe alongside the rest.
Gulp is successfully running with Yarn berry from version 4 and up. This adds it to the compatibility list. Yarn may potentially support earlier versions, but the E2E tests succeed for the 4 line, and not 3.91 and below due to varying issues.
No problem, just happy to find a way to help! I was able to get this E2E test for 4.0.2 like mentioned in that issue as well as 4.0.0. If there's another edge case to cover for their workflow it will be interesting to see what the discrepancy is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The Gulp package is still missing from the list of completed E2E tests required by #368.
How did you fix it?
I added an E2E test that installs gulp to a project as a dev dependency and tests with two short scripts.
One creates a simple default task that should run successfully when running "gulp", validating that the dependency installed and is able to run.
The next creates a public task that can be run with the "gulp " CLI argument, and validates that we're able to import and use the gulp API by making use of the src() function to load the script file in.
I look forward to any suggestions for how to expand or improve E2E coverage for Gulp. Thanks for your time!
Checklist