fix(nm): Gives hoisting priority to direct portal dependencies #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Angular E2E tests are failing, because of this issue: |
gaetanmaisse
added a commit
to storybookjs/storybook
that referenced
this pull request
Jul 27, 2021
gaetanmaisse
added a commit
to storybookjs/storybook
that referenced
this pull request
Jul 27, 2021
gaetanmaisse
added a commit
to storybookjs/storybook
that referenced
this pull request
Jul 28, 2021
arcanis
approved these changes
Aug 3, 2021
merceyz
approved these changes
Aug 3, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
In some cases portal dependencies are blocked from hoisting due to the dependency with the same name gets hoisted first from regular dependencies and blocks the way. In this case the assertion is triggered. One example of this situation is:
storybookjs/storybook#15682 (comment)
How did you fix it?
I have added static hoisting priority inside hoister (just a number, the dependencies with higher hoisting priority number get hoisted first among other dependencies). I assign direct portal dependencies with the hoisting priority 1, this lets them to be hoisted first and does not let regular dependencies take their place.
Checklist