Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an extension for CRA #2236

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Adds an extension for CRA #2236

merged 1 commit into from
Dec 13, 2020

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Dec 13, 2020

What's the problem this PR addresses?
CRA hasn't merged facebook/create-react-app#9872 yet, causing our tests to fail for two months.

How did you fix it?
I've added a forced peer dependency on React to CRA; I couldn't update react-refresh since package extensions can no longer override dependencies, but that should be enough for our tests.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 15129c1 into master Dec 13, 2020
@arcanis arcanis deleted the mael/cra-extension branch December 13, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant