[Bug] Native dependencies fail to build if the project's path contains spaces

[ngryman]

• I'd be willing to implement a fix

Describe the bug

Native dependencies fail to build if there is a space in the project's path. It's happening during the compilation phase of the dependency.

I've tracked down the error and it comes the fact we add a --require /path/to/.pnp.js in NODE_OPTIONS. The path gets truncated if it contains a space (cf. screenshot).

NODE_OPTIONS documentation mentions that options containing spaces should be escaped with a \. However when I tried to monkey patch to test if it works, it was still truncating the path. I'm not exactly sure why though...

Do you know where to properly patch the code for this, in order to test if adding a \ really works?

To Reproduce

await expect(packageJsonAndInstall({
  dependencies: {
    [`node-sass`]: `latest`
  }
})).resolves.toBeTruthy();

Screenshots

In the following path: /Users/ngryman/Projects/OSS/Code/berry spaces, here is the log of the build when running yarn add node-sass:

Environment if relevant (please complete the following information):

• OS: Mac OS Catalina
• Node version 10.17.0
• Yarn version master branch

[yarnbot]

This issue reproduces on master:

Error: expect(received).resolves.toBeTruthy()

Received: undefined
    at Object.toBeTruthy (/github/workspace/.yarn/cache/expect-npm-24.8.0-8c7640c562-1.zip/node_modules/expect/build/index.js:202:20)
    at module.exports (evalmachine.<anonymous>:6:14)
    at /github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.37-bb4398f5f1-1.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:56:19
    at executeInTempDirectory (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.37-bb4398f5f1-1.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:17:22)
    at Object.executeRepro (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.37-bb4398f5f1-1.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:24:18)
    at ExecCommand.execute (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.37-bb4398f5f1-1.zip/node_modules/@arcanis/sherlock/lib/commands/exec.js:25:59)
    at async ExecCommand.validateAndExecute (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-1.zip/node_modules/clipanion/lib/advanced/Command.js:161:26)
    at async Cli.run (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-1.zip/node_modules/clipanion/lib/advanced/Cli.js:74:24)
    at async Cli.runExit (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-1.zip/node_modules/clipanion/lib/advanced/Cli.js:83:28)

[ngryman]

Ahah it seems that I finally managed to make the repo fail correctly 🎉 Sorry for the noise 😅

[arcanis]

Can you try with Node 12? Up until then Node had a longstanding issue with that (cf my PR at nodejs/node#24065). We could add a more helpful error message, however, by checking whether semver.lt(process.versions.node, '12.0.0').

[ngryman]

@arcanis I can confirm that it works with the active LTS 👍
Yea an error message could do it. Do you think that's something I could help with?

[arcanis]

Yep, for sure!