improv: throw error if using node <12 and the path to .pnp.js include…

…s spaces (yarnpkg#716)

packages/plugin-pnp/package.json

@@ -7,7 +7,8 @@
     "@yarnpkg/plugin-stage": "workspace:^2.0.0-rc.15",
     "@yarnpkg/pnp": "workspace:^2.0.0-rc.16",
     "clipanion": "^2.1.5",
-    "micromatch": "^4.0.2"
+    "micromatch": "^4.0.2",
+    "semver": "^5.6.0"
   },
   "peerDependencies": {
     "@yarnpkg/cli": "^2.0.0-rc.27",

packages/plugin-pnp/sources/index.ts

@@ -2,6 +2,8 @@ import {Hooks as CoreHooks, Plugin, Project, SettingsType} from '@yarnpkg/core';
 import {Filename, PortablePath, npath, ppath, xfs}         from '@yarnpkg/fslib';
 import {Hooks as StageHooks}                               from '@yarnpkg/plugin-stage';
 
+import semver                                              from 'semver';
+
 import {PnpLinker}                                         from './PnpLinker';
 import unplug                                              from './commands/unplug';
 
@@ -31,6 +33,9 @@ async function setupScriptEnvironment(project: Project, env: {[key: string]: str
   const pnpPath: PortablePath = getPnpPath(project).main;
   const pnpRequire = `--require ${quotePathIfNeeded(npath.fromPortablePath(pnpPath))}`;
 
+  if (pnpPath.includes(' ') && semver.lt(process.versions.node, '12.0.0'))
+    throw new Error(`Expected the build location to not include spaces when using Node < 12.0.0 (${process.versions.node})`);
+
   if (xfs.existsSync(pnpPath)) {
     let nodeOptions = env.NODE_OPTIONS || ``;
 

yarn.lock

@@ -5335,6 +5335,7 @@ __metadata:
     "@yarnpkg/pnp": "workspace:^2.0.0-rc.16"
     clipanion: ^2.1.5
     micromatch: ^4.0.2
+    semver: ^5.6.0
   peerDependencies:
     "@yarnpkg/cli": ^2.0.0-rc.27
     "@yarnpkg/core": ^2.0.0-rc.21