New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration to extend other config files #775
Conversation
@rcoy-v thanks for this 👍 I'm currently digging out of a mound of OSS tickets, and am looking very much forward to getting to this one. |
I tested this through nyc with one of our internal projects. It fulfilled my requirement at least for extending configurations. |
@rcoy-v my only concern is projects that happen to have an we're marching towards a 7.x release, so it's a good time to add this feature. |
I agree, this is essentially adding a new reserved word. I would treat it as a major semver change. I did not update the README in this pr to detail the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for submitting!
[*.js] | ||
end_of_line = lf | ||
indent_style = space | ||
indent_size = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks for adding it! Could you perhaps add insert_final_newline = true
?
@rcoy-v mind rebasing this against the |
Closed in favor of #779. |
This is a solution to istanbuljs/nyc#503. I still need to test this with nyc, but I would like to get feedback early.
This only applies the extends functionality when
.config()
is given an object. Please let me know if there are other cases that should use this as well.