Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coerce): options using coerce now displayed in help #1911

Merged
merged 2 commits into from Apr 11, 2021
Merged

fix(coerce): options using coerce now displayed in help #1911

merged 2 commits into from Apr 11, 2021

Commits on Apr 11, 2021

  1. fix(coerce): options using coerce now displayed in help 

    The trick we were using of .alias("foo", "foo") to "tell" yargs-parser about a key
using coerce has a bug such that help output is broken. We can instead use
.key (https://github.com/yargs/yargs-parser/blob/master/lib/yargs-parser.ts#L191) which
is designed for exactly our purposes (telling yargs-parser a key exists, without
setting attributes such as description).

Fixes #1909
    @bcoe
    bcoe committed Apr 11, 2021
    Copy the full SHA
    067088b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-1909-2

    @bcoe
    bcoe committed Apr 11, 2021
    Copy the full SHA
    edb1801 View commit details
    Browse the repository at this point in the history