Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware)!: middleware improvements #1852

Merged
merged 4 commits into from Feb 16, 2021
Merged

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jan 14, 2021

  1. global middleware will now be applied when no command is configured.
  2. async middleware now works when used before validation.

BREAKING CHANGE: changes to middleware behavior:

  • validation now applied after async middleware completes when applyBeforeValidation=true
  • global middleware now applied when no command is configured

Refs: #1823
Fixes: #1351

1. global middleware will now be applied when no command is configured.
2. async middleware now works when used before validation.

BREAKING CHANGE: changes to middleware behavior:
* validation now applied after async middleware completes when applyBeforeValidation=true
* global middleware now applied when no command is configured
@bcoe bcoe merged commit e0f9363 into master Feb 16, 2021
@bcoe bcoe deleted the middleware-no-command branch February 16, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

middleware doesn't work as expected when used in isolation
1 participant