New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: improve support for async/await #1823
Merged
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0b47fdb
feat!: improve support for async/await
bcoe 8a40873
fix: address bug with execution order
bcoe d8b10f4
feat: continuing to flesh out async behavior
bcoe ae3951e
chore: add a couple notes for future work
bcoe c757bd0
Merge branch 'master' into better-async
bcoe 6f22e16
docs: make comment better
bcoe e9fdec0
Merge branch 'master' into better-async
bcoe 6ad2be0
feat: add async support to getCompletions
bcoe 27c536c
feat: implement getHelp() functionality
bcoe 73c1336
test: add test for 1791
bcoe b1d066c
build: run coverage on latest node
bcoe 7c35498
test: add additional tests for async middleware
bcoe b997eba
docs: add async examples
bcoe 924ce59
docs: wordsmith docs
bcoe e955790
docs: slight tweaks to wording
bcoe f78ee0c
docs: continuing to work on wording
bcoe 08768b1
docs: fix typo
bcoe File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note that this will be returned after the handler has finished.