chore(ts): tsify lib/argsert #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
approved these changes
Apr 7, 2020
test/types/check-output-result.ts
Outdated
| @@ -0,0 +1,7 @@ | |||
| export interface CheckOutputResult<T> { | |||
| errors: any[] | |||
| logs: any[] | |||
There was a problem hiding this comment.
could we be more specific with this type, I think these are string arrays?
There was a problem hiding this comment.
Well, we use them as string[], but their true type for now is any[], as we get their contents directly from console.{error,log,warn} first parameter message, which is any.
So if we want to have real string[] (and we should, as we always test them again string[] afterwards), we should explicitly transform message to string, using util.format for example.
Although this has nothing to do with tsification, I will add a commit to fix that.
added 7 commits
April 8, 2020 10:57
As parseCommand() is used by argsert, completion, etc.
checkOutputResult's console stubs now format strings as real console methods do (using util.format).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of the 2nd step of #1586: this PR tsifies the
lib/argsertmodule.To do so, it also:
test/helpers/utilsparseCommand()fromlib/command, into an independentlib/parse-commandmodule, to break the dependency cycle betweenlib/argsert,lib/middlewareandlib/commandparseCommand()is called with at least a one word command string (thanks typescript again)argumentsintest/argsertby an...argsnamed argument, easier to read and type, and not needing an explicit conversion to array