Don't alter the user supplied script name #1383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have a central script (
./tvui
) in the root of our repository that is used to manage everything. It is executed directly, not throughyarn
ornpm-scripts
.Problem
Using
yargs.scriptName('./tvui')
results in justtvui
being shown in all of the commands/examples. This seems to happen due to thepath.basename
call inlib/usage.js#154
.Fix
Track that the script name was set using the
scriptName
function and don't perform apath.basename
on it.