Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properties accessed on singleton now reflect current state of instance #1366

Merged
merged 3 commits into from Jul 13, 2019
Merged

fix: properties accessed on singleton now reflect current state of instance #1366

merged 3 commits into from Jul 13, 2019

Commits on Jun 19, 2019

  1. tests: reproduce parsed frozen to false (#1144)

    @mleguen
    mleguen committed Jun 19, 2019
    Copy the full SHA
    fd96bee View commit details
    Browse the repository at this point in the history

  2. fix (singletonify): parsed frozen to false (#1144) 

    singletonify() used to set Argv's properties to the singleton's
properties values _at the time of Argv's last call_.

So Argv's properties and the singleton's ones diverged
afterwards, such as parsed after a call to parse, still false
in Argv.parsed, not in singleton.parse.

singletonify() now adds setters to Argv instead, looking for the
value of the corresponding property in the singleton _at the time
the property is used_.
    @mleguen
    mleguen committed Jun 19, 2019
    Copy the full SHA
    152950b View commit details
    Browse the repository at this point in the history

  3. fix (singletonify): fix missing typeof in 152950b

    @mleguen
    mleguen committed Jun 19, 2019
    Copy the full SHA
    7822bb3 View commit details
    Browse the repository at this point in the history