middleware doesn't work as expected when used in isolation

[bcoe]

middleware doesn't work as I'd expect for yargs.argv; I would expect the middlware runs, it does not.

[wesleytodd]

I just ran into this, and here is my feedback:

• Should run even if no command is matched
• Should run for default command (it does not right now)

Right now I am doing the following:

yargs()
  .middleware(common)
  .command('$0', 'default', {}, (argv) => {
     common(argv)
    // ...
  })

function common (argv) {
  // common mw
}

This works, but it took me a bit to figure out why the middleware was not being run.

I looked into submitting a PR, but I dont have time right now to fully learn this codebase :(. If I am pointed in the right direction I might be able to work it out, but at first read I was unsure where to make the change.

[bcoe]

@wesleytodd would very much appreciate help, I can at least point you at the right files when I have some cycles.

[mleguen]

@wesleytodd I tried to reproduce this issue with your code and master branch:

• your middleware is called as expected with default command (and it is called twice with your workaround)
• middleware is not run when no command is matched... but the doc for middleware() states that the middlewares are called for commands only

So I do not think there is something to correct here.

[bcoe]

When a default command is used, middleware works as expected on the latest release (Refs: #1813).

I would like to make it so middleware is applied even if you don't specify a default command, perhaps we could refactor the codebase to always have a default command registered.

[bcoe]

Refs: #1823