Skip to content

Commit

Permalink
fix: context should override parsed argv (#786)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: context now takes precedence over argv and defaults
  • Loading branch information
bcoe committed Feb 26, 2017
1 parent a8528e6 commit 0997288
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions test/yargs.js
Expand Up @@ -768,6 +768,14 @@ describe('yargs dsl tests', function () {
a1.foo.should.equal('bar')
a1.context.should.equal('look at me go!')
})

// see https://github.com/yargs/yargs/issues/724
it('overrides parsed value of argv with context object', function () {
var a1 = yargs.parse('-x=33', {
x: 42
})
a1.x.should.equal(42)
})
})

// yargs.parse(['foo', '--bar'], function (err, argv, output) {}
Expand Down
2 changes: 1 addition & 1 deletion yargs.js
Expand Up @@ -935,7 +935,7 @@ function Yargs (processArgs, cwd, parentRequire) {
options.configuration = pkgUp()['yargs'] || {}
const parsed = Parser.detailed(args, options)
var argv = parsed.argv
if (parseContext) argv = assign(parseContext, argv)
if (parseContext) argv = assign(argv, parseContext)
var aliases = parsed.aliases

argv.$0 = self.$0
Expand Down

0 comments on commit 0997288

Please sign in to comment.