Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse options ending with 3+ hyphens #434

Merged
merged 6 commits into from Jul 5, 2022
Merged

fix: parse options ending with 3+ hyphens #434

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31d637a
fix: parse options ending with 3+ hyphens
0x2b3bfa0 Feb 5, 2022
c5ea124
Merge branch 'main' into main
bcoe Feb 27, 2022
94eeb8d
Add tests
0x2b3bfa0 Feb 27, 2022
eb36feb
Merge branch 'main' into main
0x2b3bfa0 Feb 27, 2022
427e988
Merge branch 'main' into main
0x2b3bfa0 Jun 5, 2022
87f3e12
Merge branch 'main' into main
bcoe Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/yargs-parser.ts
View file
Open in desktop
Expand Up @@ -225,7 +225,7 @@ export class YargsParser {
if (arg !== '--' && isUnknownOptionAsArg(arg)) {
pushPositional(arg)
// ---, ---=, ----, etc,
} else if (truncatedArg.match(/---+(=|$)/)) {
} else if (truncatedArg.match(/^---+(=|$)/)) {
0x2b3bfa0 marked this conversation as resolved.
Show resolved Hide resolved
// options without key name are invalid.
pushPositional(arg)
continue
Expand Down
7 changes: 7 additions & 0 deletions test/yargs-parser.cjs
View file
Open in desktop
Expand Up @@ -3588,6 +3588,13 @@ describe('yargs-parser', function () {
args.bar.should.equal('--goodnight moon')
})

// see: https://github.com/yargs/yargs-parser/issues/433
it('handles strings with three or more trailing dashes', function () {
const args = parser('--foo "hello---" --bar="world---"')
args.foo.should.equal('hello---')
args.bar.should.equal('world---')
})

it('respects inner quotes (string)', function () {
const args = parser('cmd --foo ""Hello"" --bar ""World"" --baz="":)""')
args.foo.should.equal('"Hello"')
Expand Down