bump 5.0.0-security.0 -> 5.0.1

[chharvey]

Using proper semver numbers. 5.0.0-security.0 is technically less than 5.0.0. This will pacify security errors requiring versions > 5.0.0.

GHSA-p9pc-299p-vxgp

low severity

Vulnerable versions: <= 5.0.0

Patched version: 5.0.0-security.0

Affected versions of yargs-parser are vulnerable to prototype pollution. Arguments are not properly sanitized, allowing an attacker to modify the prototype of Object, causing the addition or modification of an existing property that will exist on all objects.
Parsing the argument --foo.__proto__.bar baz' adds a bar property with value baz to all objects. This is only exploitable if attackers have control over the arguments being passed to yargs-parser.

Recommendation

Upgrade to versions 13.1.2, 15.0.1, 18.1.1 or later.

Dependabot cannot update yargs-parser to a non-vulnerable version

The latest possible version that can be installed is 5.0.0-security.0 because of the following conflicting dependency:

gulp@4.0.2 requires yargs-parser@5.0.0-security.0 via a transitive dependency on yargs@7.1.1

The earliest fixed version is 13.1.2.

[chharvey]

ping @bcoe

[rarkins]

Yes, ideally 5.0.1 would be released and the CVE updated. 5.0.0-security.0 is (a) an unstable version according to semver/npm where it's published, and (b) sorts less than 5.0.0. So if <=5.0.0 is vulnerable then that includes 5.0.0-security.0 and if the recommendation is >=5.0.0-security.0 then that includes 5.0.0 (which is actually vulnerable).

[bcoe]

I will make an effort to do this soon, patches to old branches are not automatically released, so merging this PR would not have an affect.

I will need to manually release a new version of 5.0.1.

[rarkins]

As some advice from someone who's done it, be careful you don't accidentally tag 5.0.1 as latest when you manually publish. The next step will be updating the security advisory to refer to 5.0.1. Do you know if that's something you can change?

[bcoe]

Closing in favor of #363