Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ts): init typescript conf + tsify tokenize-arg-string #272
chore(ts): init typescript conf + tsify tokenize-arg-string #272
Changes from 1 commit
7c24670
88fc857
0c8001d
37e6354
729ff4d
b6b9237
0bcfd40
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do want to continue supporting node 6 in
yargs-parser
, then the target needs to be changed intsconfig.json
(and in.eslintrc
too, I think), as node 6 supports only 17% of es2017 (see https://node.green/#ES2017).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But as I see we no longer do tests on node 6, I suggest upgrading the engines requirements to
"node": ">=8"
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mleguen @QmarkC since we're going to need to take on a breaking change any ways, let's just make it
>=10
, but I'll do this in a separate PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#278
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but opening #278 does not change the issue here: tsconfig.json and .eslintc are still incoherent with package.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mleguen engines.node in package.json has been updated to
>=10
, ESLintparserOptions.ecmaVersion
updated to2018
, and updated tsconfig.json to removees2017
so it will usees2018
fromgts/tsconfig-google.json
.This file was deleted.