Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: drops Node 6 and 4. begin following Node.js LTS schedule #89

Merged
merged 5 commits into from Aug 4, 2020
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
@@ -1,3 +1,4 @@
.DS_Store
node_modules
.nyc_output
package-lock.json
1 change: 1 addition & 0 deletions .nvmrc
@@ -0,0 +1 @@
lts/*
6 changes: 4 additions & 2 deletions .travis.yml
@@ -1,7 +1,9 @@
language: node_js
sudo: false
node_js:
- "4"
- "6"
- "10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we dust off these old libraries, let's switch to GitHub actions, and add automated publication/releasing, see:

https://github.com/yargs/yargs-parser/tree/master/.github/workflows

I can update the release-please.yml with the publication logic, if you add ci.yml for testing.

- "12"
- "14"
- "lts/*"
- "node"
after_success: npm run coverage
6 changes: 6 additions & 0 deletions README.md
Expand Up @@ -95,6 +95,12 @@ What locale is currently being used?

Update the current locale with the key value pairs in `obj`.

## Supported Node.js Versions

Libraries in this ecosystem make a best effort to track
[Node.js' release schedule](https://nodejs.org/en/about/releases/). Here's [a
post on why we think this is important](https://medium.com/the-node-js-collection/maintainers-should-consider-following-node-js-release-schedule-ab08ed4de71a).

## License

ISC
Expand Down
35 changes: 19 additions & 16 deletions package.json
Expand Up @@ -2,31 +2,31 @@
"name": "y18n",
"version": "4.0.0",
"description": "the bare-bones internationalization library used by yargs",
"main": "index.js",
"scripts": {
"pretest": "standard",
"test": "nyc mocha",
"coverage": "nyc report --reporter=text-lcov | coveralls",
"release": "standard-version"
"keywords": [
"i18n",
"internationalization",
"yargs"
],
"homepage": "https://github.com/yargs/y18n",
"bugs": {
"url": "https://github.com/yargs/y18n/issues"
},
"repository": {
"type": "git",
"url": "git@github.com:yargs/y18n.git"
},
"license": "ISC",
"author": "Ben Coe <ben@npmjs.com>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but we should probably switch my email to bencoe@gmail.com.

"main": "index.js",
"files": [
"index.js"
],
"keywords": [
"i18n",
"internationalization",
"yargs"
],
"author": "Ben Coe <ben@npmjs.com>",
"license": "ISC",
"bugs": {
"url": "https://github.com/yargs/y18n/issues"
"scripts": {
"coverage": "nyc report --reporter=text-lcov | coveralls",
"release": "standard-version",
"pretest": "standard",
"test": "nyc mocha"
},
"homepage": "https://github.com/yargs/y18n",
"devDependencies": {
"chai": "^4.0.1",
"coveralls": "^3.0.0",
Expand All @@ -35,5 +35,8 @@
"rimraf": "^2.5.0",
"standard": "^10.0.0-beta.0",
"standard-version": "^5.0.0"
},
"engines": {
"node": ">=10"
}
}