Api: Move Provides.conditionals API.
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffset
force-pushed
the
wp/conditional-out-of-provides
branch
from
2e406c9
to
147940d
Compare
Instead of `@Provides(Conditional(..), Conditional(..))` it's now required to write `@Provides @conditional(..) @conditional(..)`. That is done to fix IDE's issues with `OptIn`s, where it could require the user to opt-in to conditions usage, where none were used. This also improves consistency with other parts of the API where `Conditional` is a top-level annotation. Edits in tests are necessary to separate the api classpath, as this CL introduces a breaking change.
Jeffset
force-pushed
the
wp/conditional-out-of-provides
branch
from
147940d
to
23e552e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
============================================
- Coverage 83.90% 83.87% -0.04%
- Complexity 1577 1585 +8
============================================
Files 191 191
Lines 7686 7628 -58
Branches 1428 1435 +7
============================================
- Hits 6449 6398 -51
+ Misses 732 726 -6
+ Partials 505 504 -1 ☔ View full report in Codecov by Sentry. |
byar
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Api: Move Provides.conditionals API.
Instead of
@Provides(Conditional(..), Conditional(..))it's now required to write
@Provides @conditional(..) @conditional(..).That is done to fix IDE's issues with
OptIns,where it could require the user to opt-in to
conditions usage, where none were used.
This also improves consistency with other parts
of the API where
Conditionalis a top-level annotation.Edits in tests are necessary to separate the api
classpath, as this CL introduces a breaking change.