Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slots codegen, improve test diagnostics. #149

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

Jeffset
Copy link
Collaborator

@Jeffset Jeffset commented May 7, 2024

Refactor + Fix: Refactor slot switch generator.

Fixes the hardcoded 100 slots (whoops!)
Uses chunked() call for much clearer code.

Testing: Print full compiler diagnostics.

This improves test code debugging experience.


No golden diff, no tests changed => No actual behavior is changed.

Fixes the hardcoded 100 slots (whoops!)
Uses `chunked()` call for much clearer code.
This improves test code debugging experience.
@Jeffset Jeffset added bug Something isn't working technical Related to internal project organisation, infrastructure, CI, etc. testing Related to tests labels May 7, 2024
@Jeffset Jeffset requested a review from bacecek May 7, 2024 17:41
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.89%. Comparing base (f07a196) to head (e06dad1).

Files Patch % Lines
...dex/yatagan/codegen/impl/SlotSwitchingGenerator.kt 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #149      +/-   ##
============================================
- Coverage     83.90%   83.89%   -0.02%     
+ Complexity     1577     1575       -2     
============================================
  Files           191      191              
  Lines          7686     7675      -11     
  Branches       1428     1427       -1     
============================================
- Hits           6449     6439      -10     
  Misses          732      732              
+ Partials        505      504       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffset Jeffset marked this pull request as ready for review May 7, 2024 17:52
@Jeffset Jeffset added this to the 2.0.0 milestone May 8, 2024
@Jeffset Jeffset merged commit a554fc6 into main May 8, 2024
4 checks passed
@Jeffset Jeffset deleted the wp/codegen-refactor branch May 8, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical Related to internal project organisation, infrastructure, CI, etc. testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants