Fix typo in emitter attr name #747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzmahone
force-pushed
the
retro_pr_emitter_attr_fix
branch
from
9bec231
to
3831f83
Compare
|
(added shim property for backwards compatibility with DeprecationWarning on use) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was originally directly merged to a pending 6.1 release branch, but in its current form, it's technically a breaking change, since the renamed attribute is "public" on the Emitter mixin (and thus on all Dumpers that use that mixin). The fix is fine, but should at least temporarily preserve a compatibility property for the old name that fires DeprecationWarning for some time to preserve backward compatibility for existing consumers.